fix(Text): Add separate layout thread with dispatcher access #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
force-pushed
the
issue106
branch
2 times, most recently
from
38c0726
to
7891d23
Compare
Text measurement was a bit of a performance bottleneck due to context switching from the native module thread to the dispatcher thread. Eventually, we may want to implement text measurement that does not invole cloning the RichTextBox (e.g., using DWrite APIs or Win2D), but this is progress for now. We create the layout thread from a static secondary CoreApplicationView with a Window that is never activated.
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Aug 30, 2016
…icrosoft#542)" This reverts commit 5236ff5.
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Aug 30, 2016
…icrosoft#542)" This reverts commit 5236ff5.
GantMan
pushed a commit
to infinitered/react-native-windows
that referenced
this pull request
Sep 29, 2016
…ft#542) Text measurement was a bit of a performance bottleneck due to context switching from the native module thread to the dispatcher thread. Eventually, we may want to implement text measurement that does not invole cloning the RichTextBox (e.g., using DWrite APIs or Win2D), but this is progress for now. We create the layout thread from a static secondary CoreApplicationView with a Window that is never activated.
GantMan
pushed a commit
to infinitered/react-native-windows
that referenced
this pull request
Sep 29, 2016
…icrosoft#542) This reverts commit 5236ff5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text measurement was a bit of a performance bottleneck due to context switching from the native module thread to the dispatcher thread.
Eventually, we may want to implement text measurement that does not invole cloning the RichTextBox (e.g., using DWrite APIs or Win2D), but this is progress for now.
We create the layout thread from a static secondary CoreApplicationView with a Window that is never activated.